From: "Paul Smedley" <ecs-isp@2rosenthals.com>
Message-ID: <bc542d89-ae56-40d5-9ea8-767021e9eae3@smedley.id.au>
Date: Wed, 18 Oct 2023 13:54:17 +1030
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [eCS-ISP] ClamAV - USE_MPOOL
To: eCS ISP Mailing List <ecs-isp@2rosenthals.com>
References: <list-8123126@2rosenthals.com>
Content-Language: en-AU
In-Reply-To: <list-8123126@2rosenthals.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Steven,

On 18/10/23 11:44, Steven Levine wrote:
> In <list-8113084@2rosenthals.com>, on 10/15/23
>     at 05:45 PM, "Paul Smedley" <ecs-isp@2rosenthals.com> said:
>
> Hi Paul,
>
> Is there a reason you are not building with USE_MPOOL?  Looking at:
>
> libclamav\mpool.c:637
> void *mpool_malloc(struct MP *mp, size_t size)
>
> and friends, the OS/2 code seems to be in place to support mpool using
> DosAllocMem rather than mmap.  However, it looks like configure is missing
> the code to allow OS/2 to enable mpool support.  Looking at
>
> configure:22851
> have_mempool="no"
> if test "$enable_mempool" = "yes"; then
>
> configure will not allow enable_mempool because it assumes that OS/2 is
> going to use mmap to implement the pool.

I hacked clamav-config.h to enable mpool and rebuilt.

It seems to work - 
https://smedley.id.au/tmp/clamav-0.103.10-os2-20231018-debug.zip

> BTW, when you get a moment, please commit your configure and build cmd
> files to the repo.  They are a useful reference.

Will do when I figure out mods to 
https://github.com/psmedley/clamav-os2/blob/main/m4/reorganization/code_checks/mpool.m4 
and/or build with cmake.

Cheers,

Paul